Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly handle meta tags with no name while extracting metadata #2835

Merged
merged 1 commit into from Jun 12, 2017

Conversation

@punchagan
Copy link
Member

@punchagan punchagan commented Jun 12, 2017

Pull Request Checklist

  • I’ve read the guidelines for contributing.
  • I updated AUTHORS.txt and CHANGES.txt (if the change is non-trivial) and documentation (if applicable).
  • I tested my changes.

Description

meta tags with no name attribute cause the metadata extraction to crash - for instance <meta charset='utf-8'>

@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented Jun 12, 2017

I’m not releasing v7.7.9 for this, at least not today.

(Insert favorite expletive here)

Loading

@Kwpolska Kwpolska merged commit 0eb37c0 into master Jun 12, 2017
0 of 5 checks passed
Loading
@Kwpolska Kwpolska deleted the fix-html-metadata branch Jun 12, 2017
@ralsina
Copy link
Member

@ralsina ralsina commented Jun 12, 2017

Oh, boy, I suck :-(

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants