Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NIKOLA_SHOW_TRACEBACKS environment variable #2858

Merged
merged 1 commit into from Jul 3, 2017
Merged

Conversation

@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented Jul 3, 2017

Not showing tracebacks to end-users is generally fine, but as a developer, it’s pretty annoying. On the other hand, NIKOLA_DEBUG=1 floods the console with useless Yapsy debug messages.

So, the fix: add NIKOLA_SHOW_TRACEBACKS that shows tracebacks but no debug stuff (as a middle ground).

Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@Kwpolska Kwpolska requested a review from ralsina Jul 3, 2017
ralsina
ralsina approved these changes Jul 3, 2017
Copy link
Member

@ralsina ralsina left a comment

Great idea!

@Kwpolska
Copy link
Member Author

@Kwpolska Kwpolska commented Jul 3, 2017

(FYI, I added it to my .zshrc to make stuff easier.)

@Kwpolska Kwpolska merged commit fe76832 into master Jul 3, 2017
3 of 5 checks passed
@Kwpolska Kwpolska deleted the env-show-tracebacks branch Jul 3, 2017
@tritium21
Copy link
Contributor

@tritium21 tritium21 commented Jul 7, 2017

If this wasn't already merged, I would have suggested making NIKOLA_DEBUG a non-boolean option. Or, at least accept other values for levels of verbosity (with '1', 'true', 'yes' defaulting to current behavior.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants