Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snap: Use the current checkout as source of the snap #2873

Merged
merged 1 commit into from Jul 17, 2017

Conversation

@uli-heller
Copy link
Contributor

@uli-heller uli-heller commented Jul 17, 2017

Pull Request Checklist

  • I’ve read the guidelines for contributing.
  • I updated AUTHORS.txt and CHANGES.txt (if the change is non-trivial) and documentation (if applicable).
  • I tested my changes.

Description

With this PR, the currently active checkout is used when creating the snap package
instead of the head of the github master.

I'm not sure if this PR is actually a good idea. I just needed a similar approach to build a
snap package of nikola-7.8.9.

@Kwpolska Kwpolska requested a review from ralsina Jul 17, 2017
@uli-heller uli-heller force-pushed the uli-heller:fix-snap-current-branch branch from 7a54ae9 to 47a74fa Jul 17, 2017
@ralsina
Copy link
Member

@ralsina ralsina commented Jul 17, 2017

Yes, it's perfectly fine.

@ralsina ralsina merged commit 0e59c7f into getnikola:master Jul 17, 2017
3 checks passed
3 checks passed
codacy/pr Good work! A positive pull request.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
uli-heller added a commit to uli-heller/nikola that referenced this pull request Jul 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants