Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow post and config arguments of metadata_extractors.check_conditions to be None #2878

Merged
merged 1 commit into from Jul 24, 2017

Conversation

@felixfontein
Copy link
Contributor

@felixfontein felixfontein commented Jul 24, 2017

Makes the function more flexible. For getnikola/plugins#241 (at least post being None).

@felixfontein
Copy link
Contributor Author

@felixfontein felixfontein commented Jul 24, 2017

Hmm, maybe allowing config to be None is a bit too much. What do you think?

@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented Jul 24, 2017

Yeah, it’s too much.

@felixfontein felixfontein force-pushed the extend-check-conditions branch from 5ebf564 to 10d75a0 Jul 24, 2017
@felixfontein
Copy link
Contributor Author

@felixfontein felixfontein commented Jul 24, 2017

I changed it. I decided to force-push this so that this minimal change won't have two commits.

@Kwpolska Kwpolska merged commit 851bca1 into master Jul 24, 2017
5 checks passed
5 checks passed
codacy/pr Good work! A positive pull request.
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@felixfontein
Copy link
Contributor Author

@felixfontein felixfontein commented Jul 24, 2017

Thanks for idea, review and merging! :)

@felixfontein felixfontein deleted the extend-check-conditions branch Jul 24, 2017
felixfontein added a commit to getnikola/plugins that referenced this pull request Jul 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants