Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Absolute paths in path handlers #2879

Merged
merged 4 commits into from Jul 24, 2017
Merged

Absolute paths in path handlers #2879

merged 4 commits into from Jul 24, 2017

Conversation

@vkazanov
Copy link
Contributor

@vkazanov vkazanov commented Jul 24, 2017

The branch does the following changes to Nikola.path:

  1. Makes try..except more granular, i.e. the exception only wraps the code that is expected to throw KeyError here.

  2. If path handler returns a string the it is considered to be a complete absolute URL not requiring any processing.

Fixes #2876

The returned value is always a path relative to output, like
"categories/whatever.html"
The returned value is either a path relative to output, like "categories/whatever.html", or
an absolute URL ("https://en.wikipedia.org/wiki/Nikola"), if path handler returns a string.

This comment has been minimized.

@Kwpolska

Kwpolska Jul 24, 2017
Member

(A better sample URL would be https://getnikola.com/)

This comment has been minimized.

@vkazanov

vkazanov Jul 24, 2017
Author Contributor

True, will fix in a sec

@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented Jul 24, 2017

Thanks for contributing to Nikola! 🎉

@Kwpolska Kwpolska merged commit 58e847d into getnikola:master Jul 24, 2017
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
codacy/pr Good work! A positive pull request.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@vkazanov vkazanov deleted the vkazanov:absolute-paths-in-path-handlers branch Jul 24, 2017
@vkazanov
Copy link
Contributor Author

@vkazanov vkazanov commented Jul 24, 2017

Great! Thank you for handling the issue in the fastest way possible.

BTW, what are the plans for the 8.0.0 milestone? A deadline or something? Currently I use a patched 7.8.9, which means I can't publish the plugin (external link bibliography) officially.

@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented Jul 24, 2017

There is currently no planned release date; however it will take a few more months to complete our plans. You can release your plugin to the repo as v8-only, telling interested users that they need either a manual patch, or the development version from GitHub.

@vkazanov
Copy link
Contributor Author

@vkazanov vkazanov commented Jul 24, 2017

Ok, thanks for clarifying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants