Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to classic confinement for snap packages #2885

Merged
merged 1 commit into from Aug 8, 2017

Conversation

@willdeberry
Copy link
Contributor

willdeberry commented Aug 8, 2017

This allows things like nikola deploy to work again since they would have
access to the running system's version of rsync.

Pull Request Checklist

  • I’ve read the guidelines for contributing.
  • I updated AUTHORS.txt and CHANGES.txt (if the change is non-trivial) and documentation (if applicable).
  • I tested my changes.

Description

@Kwpolska Kwpolska requested a review from ralsina Aug 8, 2017
@Kwpolska

This comment has been minimized.

Copy link
Member

Kwpolska commented Aug 8, 2017

It looks like your commit was misattributed. Please add the e-mail address you used for this commit (@gmail.com) to your GitHub profile so your commits will appear as yours.

@willdeberry willdeberry force-pushed the willdeberry:snap-classic branch from cc74e78 to 16c7d78 Aug 8, 2017
This allows things like `nikola deploy` to work again since they would have
access to the running system's version of `rsync`.
@willdeberry willdeberry force-pushed the willdeberry:snap-classic branch from 16c7d78 to b664417 Aug 8, 2017
@willdeberry

This comment has been minimized.

Copy link
Contributor Author

willdeberry commented Aug 8, 2017

I thought I addressed this, sorry for that.

@willdeberry willdeberry changed the title git Switch to classic confinement for snap packages Switch to classic confinement for snap packages Aug 8, 2017
@ralsina
ralsina approved these changes Aug 8, 2017
@ralsina

This comment has been minimized.

Copy link
Member

ralsina commented Aug 8, 2017

Let's do this, if it breaks something we'll fix it.

@ralsina ralsina merged commit 20c5800 into getnikola:master Aug 8, 2017
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
codacy/pr Good work! A positive pull request.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.