New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thumbnail shortcode, take 2 #2904

Merged
merged 5 commits into from Sep 19, 2017

Conversation

Projects
None yet
3 participants
@Kwpolska
Copy link
Member

Kwpolska commented Sep 19, 2017

Adds a less basic thumbnail shortcode with alt and align options, as well as caption support.

Supersedes / Closes #2903. Via Issue #2809.

Kwpolska added some commits Sep 19, 2017

Sort shortcode list alphabetically
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Add thumbnail shortcode
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Thumbnail caption should be a HTML fragment
Signed-off-by: Chris Warrick <kwpolska@gmail.com>

@Kwpolska Kwpolska requested a review from ralsina Sep 19, 2017

Make Codacy happier
Signed-off-by: Chris Warrick <kwpolska@gmail.com>

@getnikola getnikola deleted a comment from codacy-bot Sep 19, 2017

@getnikola getnikola deleted a comment from codacy-bot Sep 19, 2017

Remove unnecessary newline
Signed-off-by: Chris Warrick <kwpolska@gmail.com>

@getnikola getnikola deleted a comment from codacy-bot Sep 19, 2017


name = "thumbnail"

def handler(self, uri, alt=None, align=None, target=None, site=None, data=None, lang=None, post=None):

This comment has been minimized.

@codacy-bot

@Kwpolska Kwpolska merged commit b19f9a4 into master Sep 19, 2017

2 of 5 checks passed

codacy/pr Not so good... This pull request quality could be better.
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@Kwpolska Kwpolska deleted the thumbnail-shortcode-2 branch Sep 19, 2017

@Kwpolska

This comment has been minimized.

Copy link
Member Author

Kwpolska commented Sep 19, 2017

Thanks for reviewing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment