Eddiefiggie patch 1 #2914
Merged
Eddiefiggie patch 1 #2914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
Oct 29, 2017
The original error, for the novice may not be as clear is it might others be. At first glance it appears to be a setting change someone needs to make within Nikola versus the OS. I believe this trivial adjustment is a bit more explicit.
I believe the proposed error message is a bit more explicit. When I first encountered this error as a user I was a bit confused. I wasn't sure, at first, if $EDITOR was a Nikola setting. Also, the second sentence wasn't clear on what "must be done manually ($EDITOR or the post)." Semantics granted, but those were my personal first impressions and thought this might help make it clearer. Also, this is my first ever attempt at a pull request. :) So I changed this: "$EDITOR not set, cannot edit the post. Please do it manually." With this: "$EDITOR not set within the operating system, cannot edit the post with \'-e\'. Post must be altered manually."
|
Don’t mind at all. Appreciate the consideration. This is an excellent project. Absolutely love it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Pull Request Checklist
Description
When your environmental variable $EDITOR is not mapped, and you use the following command "nikola new_post -e", you currently get the following error message:
"$EDITOR not set, cannot edit the post. Please do it manually."
As a user, I was a little confused by this. The first sentence sent me searching for a Nikola setting where I can set the preferred editor. The second sentence had me contemplating if I needed to edit the "setting" within Nikola manually or the post I just made. These were first thoughts when I read the message.
I thought, perhaps, you might use this proposed message so to be a bit more explicit. I tried to keep the words to a minimum while still being as clear as possible.
"$EDITOR not set within the operating system, cannot edit the post with '-e'. Post must be altered manually."
I'm hopeful this might prove valuable to some users in the future.