Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Baguette in bootstrap #2929

Merged
merged 9 commits into from Dec 26, 2017
Merged

Baguette in bootstrap #2929

merged 9 commits into from Dec 26, 2017

Conversation

@ralsina
Copy link
Member

ralsina commented Dec 4, 2017

  • Use baguetteJS (nicer, smaller, faster than colorbox) in bootstrap theme.
  • Remove colorbox

This change is backwards-incompatible since it's bound to break people's themes.

@ralsina ralsina mentioned this pull request Dec 4, 2017
1 of 3 tasks complete
<!-- fancy dates -->
<script>
moment.locale("${momentjs_locales[lang]}");
fancydates(${date_fanciness}, ${js_date_format});
</script>
<!-- end fancy dates -->
<%block name="extra_js"></%block>
<script>baguetteBox.run('a.reference', {

This comment has been minimized.

Copy link
@Kwpolska

Kwpolska Dec 4, 2017

Member

Why did we change the classes baguetteBox works with?

This comment has been minimized.

Copy link
@ralsina

ralsina Dec 4, 2017

Author Member

That's copied from base theme. Probably both should be what was in bootstrap instead.

I'll take a look at it tomorrow.

This comment has been minimized.

Copy link
@Kwpolska

This comment has been minimized.

Copy link
@ralsina

ralsina Dec 26, 2017

Author Member

This seems to work in the demo cases. Since baguette is not JQuery based, I don't see a simple way to use that complex selector :-(

@ralsina
Copy link
Member Author

ralsina commented Dec 11, 2017

@Kwpolska
Copy link
Member

Kwpolska commented Dec 26, 2017

Please backport the .islink thing back to base and run jinjify again.

Copy link
Member

Kwpolska left a comment

Okay, so .islink is kinda different, but eh, it’s good enough.

Kwpolska added 2 commits Dec 26, 2017
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@Kwpolska Kwpolska merged commit 05b1fd1 into master Dec 26, 2017
3 of 5 checks passed
3 of 5 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
Codacy/PR Quality Review Good work! A positive pull request.
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@Kwpolska Kwpolska deleted the baguette-in-bootstrap branch Dec 26, 2017
@ralsina
Copy link
Member Author

ralsina commented Dec 27, 2017

Thanks for merging and reviewing @Kwpolska

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.