Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doit clean #2980

Merged
merged 3 commits into from Mar 13, 2018
Merged

Fix doit clean #2980

merged 3 commits into from Mar 13, 2018

Conversation

@ralsina
Copy link
Member

@ralsina ralsina commented Mar 13, 2018

Doit 0.31 changes the DoitClean API, this makes it work.

Copy link
Member

@Kwpolska Kwpolska left a comment

Kinda ugly, but it works. Perhaps add a comment to explain it? (We could also drop support for doit <=0.31.0, although that doesn’t really matter.)

@ralsina ralsina merged commit a976064 into master Mar 13, 2018
0 of 3 checks passed
0 of 3 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@Kwpolska Kwpolska deleted the fix-doit-clean branch Mar 31, 2018
Kwpolska added a commit that referenced this pull request Mar 31, 2018
* Use doit clean as required by doit 0.31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants