Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use .rst as extension for all reStructured files we ship #2983

Merged
merged 6 commits into from Mar 17, 2018
Merged

Conversation

@ralsina
Copy link
Member

ralsina commented Mar 15, 2018

I think I caught it all.

@Kwpolska
Copy link
Member

Kwpolska commented Mar 15, 2018

Update the symlinks list please.

@ralsina
Copy link
Member Author

ralsina commented Mar 15, 2018

@Kwpolska done

@Kwpolska
Copy link
Member

Kwpolska commented Mar 15, 2018

AppVeyor still fails:

error: [Errno 2] No such file or directory: 'C:\\Users\\appveyor\\AppData\\Local\\Temp\\1\\pip-66af395j-build\\docs\\sphinx\\creating-a-theme.rst'
@Kwpolska
Copy link
Member

Kwpolska commented Mar 15, 2018

Did you forget to git add some files?

Copy link
Member

Kwpolska left a comment

still fails AppVeyor tests (missing files?)

@ralsina
Copy link
Member Author

ralsina commented Mar 15, 2018

I just fixed a conflict, will take a look again later (no more time)

@ralsina
Copy link
Member Author

ralsina commented Mar 15, 2018

@Kwpolska seems to be just invariance now?

@Kwpolska
Copy link
Member

Kwpolska commented Mar 15, 2018

@ralsina
Copy link
Member Author

ralsina commented Mar 16, 2018

@Kwpolska I have no idea how that works on windows. The symlink is there...

@Kwpolska
Copy link
Member

Kwpolska commented Mar 16, 2018

@ralsina
Copy link
Member Author

ralsina commented Mar 17, 2018

Ok, was not pushed. Let's see now.

@Kwpolska Kwpolska merged commit 10b4a15 into master Mar 17, 2018
3 of 5 checks passed
3 of 5 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
Codacy/PR Quality Review Good work! A positive pull request.
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@Kwpolska Kwpolska deleted the use-rst-extension branch Mar 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.