Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Bootstrap 4 implementation #2991

Merged
merged 17 commits into from Mar 18, 2018
Merged

Initial Bootstrap 4 implementation #2991

merged 17 commits into from Mar 18, 2018

Conversation

@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented Mar 18, 2018

This implements parts of #2964:

  • implements bootstrap4, which looks similarly to the classic Bootstrap themes (bootstrap3 and bootstrap2)
  • replaces flowr.js with justified-layout.js, which does not require jQuery, is actively maintained, and comes directly from Flickr (yay for open source!)
  • implements parts of the bootblog4 theme (the base layout is mostly there)

Not done yet, in bootblog4:

  • featured posts, which I’d prefer to handle as a core feature available to all willing themes
  • the sidebar might not make the cut, or become a configurable optional feature
  • the footer uses our standard styles right now
  • bootblog4-jinja

I feel this is mergeable, and other parts can be done as future PRs.

Kwpolska added 15 commits Mar 18, 2018
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@Kwpolska Kwpolska added this to the v8.0.0 milestone Mar 18, 2018
@Kwpolska Kwpolska requested a review from ralsina Mar 18, 2018
@ralsina
Copy link
Member

@ralsina ralsina commented Mar 18, 2018

I am all for it. We will never get the v8 omelette done unless we start breaking some v8 eggs.

Kwpolska added 2 commits Mar 18, 2018
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@getnikola getnikola deleted a comment Mar 18, 2018
@Kwpolska Kwpolska merged commit 695e224 into master Mar 18, 2018
3 of 5 checks passed
@Kwpolska Kwpolska deleted the bootstrap4 branch Mar 18, 2018
@Kwpolska Kwpolska added this to Done in Version 8 Apr 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Version 8
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants