Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Add ATOM_PATH setting #3015
Now i have a shell with the dependencies installed and nikola installed with
Nix is a great help as it has this integrated: https://nixos.org/nixpkgs/manual/#development-mode
This works at least on Linux, on macOS is a dependency missing i think. Would you like a PR for that?
Now i'm able to build my website, no change in atom path as expected.
felixfontein left a comment
Looks good, except: in case
@felixfontein Nix does that, this way pip installs every dependency that is not installed by Nix into /tmp/.... This way you get a temporary development environment without messing up your python install.
When i set
the links in the
Now the RSS and Atom link are similar, but have strange file names. Still breaking backwards compatibility.
With this setting
the links are
I can set this for Atom and leave RSS as is, then it's backwards compatible. But we should change this in 8.0 to have consistent links among RSS and Atom by default.
I can't set it like this in
NameError: name 'INDEX_PATH' is not defined
I have to sleep now. Day is dawning already.
As you noticed in #3016, Atom feeds work differently to RSS. We generate them with the same data as
This feature will be v8-only.
To do this properly, you’d do it after config is loaded from
config['ATOM_PATH'] = config['ATOM_PATH'] if config['ATOM_PATH'] else config['INDEX_PATH'] # ninja edit: config['ATOM_PATH'] = config['ATOM_PATH'] or config['INDEX_PATH']
I don’t think we need that. The more typical route (virtualenv +
@Kwpolska What is the reason for that? It seems not to be useful to subscribe to the
With your suggested change, i get
That can be achived with this lines added in nikola.py at line 616:
I suggest to have the same behavior with RSS and Atom path, at least in 8 since it breaks backwards compatibility.
That’s the way this feature was written. I suppose the use-case was to have pagination between atom feeds. But perhaps we could clean it up and drop that?
My code snippet was just an untested example. That said, if you’re letting people customize the path, you should also ask for the file extension (some people might want
If there is no good reason for this behavior, sure. That's a topic for the other issue.
My first idea was to have
What default behavior do you want for this feature?
I've tried running your branch with one of my blogs, and I got:
I didn't set
@felixfontein i have also tested it with my blog and default
URLs as expected:
And also with
and no change with
That was my initial requirement for this feature, great.