Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use basic ipynb template by default for slightly better appearance and behavior #3020

Merged
merged 2 commits into from Apr 15, 2018

Conversation

@Kwpolska
Copy link
Member

commented Apr 13, 2018

This removes #notebook and #notebook-container from ipynb posts.

h/t @gramster for making me look at nbexport config options in #3019 and noticing this discrepancy.

--- index.html	2018-04-13 19:06:38.000000000 +0200
+++ old.html	2018-04-13 19:04:46.000000000 +0200
@@ -92,7 +92,9 @@
         
 
     </header><div class="e-content entry-content" itemprop="articleBody text">
-    <div>
+    <div tabindex="-1" id="notebook" class="border-box-sizing">
+    <div class="container" id="notebook-container">
+
 <div class="cell border-box-sizing text_cell rendered">
 <div class="prompt input_prompt">
 </div>
@@ -544,7 +546,9 @@
 </div>
 </div>
 </div>
-</div>
+    </div>
+  </div>
+
     </div>
     <aside class="postpromonav"><nav><ul class="pager hidden-print">
 <li class="previous">
Use basic ipynb template by default
Signed-off-by: Chris Warrick <kwpolska@gmail.com>

@Kwpolska Kwpolska added the minor label Apr 13, 2018

@Kwpolska Kwpolska added this to the v8.0.0 milestone Apr 13, 2018

@Kwpolska Kwpolska requested review from ralsina and damianavila Apr 13, 2018

@Kwpolska Kwpolska merged commit df80757 into master Apr 15, 2018

5 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@Kwpolska Kwpolska deleted the ipynb-basic-template branch Apr 15, 2018

@Kwpolska

This comment has been minimized.

Copy link
Member Author

commented Apr 15, 2018

Thanks for reviewing!

PS. You might have forgotten to press merge, and I misinterpreted the commit e-mail. Double brain fart.

@damianavila

This comment has been minimized.

Copy link
Member

commented Apr 16, 2018

I need to test this one but seems a reasonable change. Sorry for the delayed feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.