Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3025 — add METADATA_VALUE_MAPPING and smartjoin #3037

Merged
merged 4 commits into from Apr 16, 2018
Merged

Fix #3025 — add METADATA_VALUE_MAPPING and smartjoin #3037

merged 4 commits into from Apr 16, 2018

Conversation

@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented Apr 15, 2018

This adds METADATA_VALUE_MAPPING and smartjoin for #3025 — it fixes the original issue and adds some nifty things.

cc @felixfontein, @tbm.

Copy link
Contributor

@felixfontein felixfontein left a comment

LGTM, except that METADATA_VALUE_MAPPING is another setting which requires conf.py to contain Python code (see #2475)

Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@Kwpolska
Copy link
Member Author

@Kwpolska Kwpolska commented Apr 15, 2018

We can’t work around those Python settings, sorry. Unless we do eval on text from the YAML.

@Kwpolska Kwpolska requested a review from felixfontein Apr 15, 2018
Copy link
Contributor

@felixfontein felixfontein left a comment

LGTM

Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@Kwpolska Kwpolska merged commit ce168a7 into master Apr 16, 2018
5 checks passed
@Kwpolska Kwpolska deleted the fix-3025 branch Apr 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants