Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2987, fix #3008 — treat compiler metadata as fallback-ish #3063

Merged
merged 4 commits into from Apr 26, 2018

Conversation

@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented Apr 25, 2018

Fix #2987 and fix #3008 by reordering metadata so that compiler meta can be overridden with comment/YAML metadata.

Kwpolska added 4 commits Apr 25, 2018
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@Kwpolska Kwpolska added the bug label Apr 25, 2018
@Kwpolska Kwpolska added this to the v8.0.0 milestone Apr 25, 2018
@Kwpolska Kwpolska requested a review from ralsina Apr 25, 2018
@ralsina ralsina merged commit f6eb249 into master Apr 26, 2018
5 checks passed
@ralsina ralsina deleted the compiler_meta_is_fallbackish branch Apr 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants