Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arbitrary metadata for galleries (#3050) #3064

Merged
merged 2 commits into from May 2, 2018
Merged

Conversation

@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented Apr 26, 2018

This fixes #3050.

cc @jmcp. (btw, there was a bug with order: 0 being ignored)

Kwpolska added 2 commits Apr 26, 2018
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@jmcp
Copy link
Contributor

@jmcp jmcp commented Apr 26, 2018

Looks good - and thankyou for catching that bug.

@Kwpolska Kwpolska requested a review from felixfontein Apr 26, 2018
@ralsina
ralsina approved these changes May 2, 2018
@Kwpolska Kwpolska merged commit 079ef5c into master May 2, 2018
3 of 5 checks passed
3 of 5 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@Kwpolska Kwpolska deleted the gallery-arbitrary-metadata branch May 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants