Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop useless settings #3065

Merged
merged 6 commits into from May 2, 2018
Merged

Drop useless settings #3065

merged 6 commits into from May 2, 2018

Conversation

@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented Apr 26, 2018

The following settings have been removed. Nikola will now always behave as if the value was what is displayed afer the setting name.

  • FEED_PREVIEWIMAGE = True
  • SITEMAP_INCLUDE_FILELESS_DIRS = True
  • USE_OPEN_GRAPH = True
  • USE_BASE_TAG = False

This is part of #2840. Not all settings listed there were deleted.

Kwpolska added 5 commits Apr 26, 2018
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@ralsina
Copy link
Member

@ralsina ralsina commented May 2, 2018

Other than the conflicts, LGTM +1

@ralsina
ralsina approved these changes May 2, 2018
@Kwpolska Kwpolska merged commit 477f9a0 into master May 2, 2018
0 of 4 checks passed
0 of 4 checks passed
Codacy/PR Quality Review Hang in there, Codacy is reviewing your Pull request.
Details
continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@Kwpolska Kwpolska deleted the drop-useless-settings branch May 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants