New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assorted gallery metadata fixes (#3076 #3077 #3078) #3079

Merged
merged 3 commits into from May 8, 2018

Conversation

Projects
None yet
2 participants
@Kwpolska
Member

Kwpolska commented May 8, 2018

Fixes #3076, fixes #3077 (None/null handling for metadata.yml captions)
Fixes #3078 (issues with multilingual sites)
Fixes an oversight which lead to USE_FILENAME_AS_TITLE being ignored in galleries with meta files.

Kwpolska added some commits May 8, 2018

Fix #3078 — make gallery metadata work for multilingual sites
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Respect USE_FILENAME_AS_TITLE in galleries with a meta file
Signed-off-by: Chris Warrick <kwpolska@gmail.com>

@Kwpolska Kwpolska added bug i18n labels May 8, 2018

@Kwpolska Kwpolska added this to the v8.0.0 milestone May 8, 2018

Fix #3076, fix #3077 — Guard against null items in gallery meta files
Signed-off-by: Chris Warrick <kwpolska@gmail.com>

@Kwpolska Kwpolska changed the title from Fix #3078 — make gallery metadata work for multilingual sites to Assorted gallery metadata fixes (#3076 #3077 #3078) May 8, 2018

@ralsina

ralsina approved these changes May 8, 2018

@Kwpolska Kwpolska merged commit daa0cd0 into master May 8, 2018

5 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@Kwpolska Kwpolska deleted the gallery-meta-fixes branch May 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment