Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support CATEGORY_DESTPATH_NAMES with pages following destpath #3085

Merged
merged 3 commits into from May 10, 2018

Conversation

@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented May 9, 2018

This should make stuff work properly for all cases I can think of.

hat tip @tbm (I used your website for testing)

Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@Kwpolska Kwpolska added the bug label May 9, 2018
@Kwpolska Kwpolska added this to the v8.0.0 milestone May 9, 2018
@getnikola getnikola deleted a comment May 10, 2018
@getnikola getnikola deleted a comment May 10, 2018
Copy link
Contributor

@felixfontein felixfontein left a comment

LGTM

nikola/nikola.py Outdated
destpath_names_reverse[lang] = {}
for k, v in self.config['CATEGORY_DESTPATH_NAMES'](lang).items():
destpath_names_reverse[lang][v] = k
self.config['_CATEGORY_DESTPATH_NAMES_REVERSE'] = utils.TranslatableSetting('_CATEGORY_DESTPATH_NAMES_REVERSE', destpath_names_reverse, self.config['TRANSLATIONS'])
Copy link
Contributor

@felixfontein felixfontein May 10, 2018

What do you think about doing this computation in the categories plugin (in its set_site method) and storing the result there?
I'm currently tending to prefer this, but I'm not really sure...

Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@Kwpolska Kwpolska merged commit 9e63e14 into master May 10, 2018
4 of 5 checks passed
@Kwpolska Kwpolska deleted the category_destpath_names_compat_for_follow branch May 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants