Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix post dependency calculations #3113

Merged
merged 4 commits into from Jul 5, 2018
Merged

Fix post dependency calculations #3113

merged 4 commits into from Jul 5, 2018

Conversation

@ralsina
Copy link
Member

@ralsina ralsina commented Jul 5, 2018

There are some bugs in post dependency calculations.

  • Post.deps returns repeated files
  • Post.fragment_deps returns nothing on default_lang when it should use a translation's sources (This is issue #3112)
Roberto Alsina and others added 3 commits Jul 5, 2018
Roberto Alsina
Copy link
Member

@Kwpolska Kwpolska left a comment

LGTM

@ralsina ralsina merged commit a98a812 into master Jul 5, 2018
0 of 5 checks passed
0 of 5 checks passed
Codacy/PR Quality Review Hang in there, Codacy is reviewing your Pull request.
Details
continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@ralsina ralsina deleted the fix-3112 branch Jul 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants