Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart data files #3130

Merged
merged 5 commits into from Aug 6, 2018
Merged

Chart data files #3130

merged 5 commits into from Aug 6, 2018

Conversation

@ralsina
Copy link
Member

@ralsina ralsina commented Aug 2, 2018

Add a data_file option to chart shortcode and directive as sort-of-per #3129

docs/manual.rst Outdated
'Firefox', [None, None, 0, 16.6, 25, 31]
'Chrome', [None, None, None, None, None, None]
'IE', [85.8, 84.6, 84.7, 74.5, 66, 58.6]
'Others', [14.2, 15.4, 15.3, 8.9, 9, 10.4]
{{% /chart %}}{{% /raw %}}
{{% /chart %}}
Copy link
Member

@Kwpolska Kwpolska Aug 2, 2018

they need to be on the same line

Copy link
Member Author

@ralsina ralsina Aug 6, 2018

Sigh. Fixing.

{{% raw %}}{{% chart Bar title='Browser usage evolution (in %)' %}}
x_labels='["2002","2003","2004","2005","2006","2007","2008","2009","2010","2011","2012"]'%}}
{{% raw %}}{{% chart Bar title='Browser usage evolution (in %)'
x_labels='["2002","2003","2004","2005","2006","2007"]' %}}
Copy link
Member

@Kwpolska Kwpolska Aug 2, 2018

Is this a syntax change or a fix to the docs?

Copy link
Member Author

@ralsina ralsina Aug 6, 2018

Just a fix for the docs, things were different lengths

Copy link
Member

@Kwpolska Kwpolska Aug 6, 2018

You moved x_labels from “inside” the shortcode to its arguments.

Copy link
Member Author

@ralsina ralsina Aug 6, 2018

Hmmm that was broken, I think.

try:
options[k] = literal_eval(v)
for k, v in options.items():
try: options[k] = literal_eval(v)
Copy link
Member

@Kwpolska Kwpolska Aug 2, 2018

why is this on one line?

@getnikola getnikola deleted a comment Aug 2, 2018
@ralsina ralsina merged commit 69ef41d into master Aug 6, 2018
1 of 4 checks passed
@Kwpolska Kwpolska deleted the chart-data-files branch Sep 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants