Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gallery: don't generate index page on empty output folder #3134

Merged
merged 1 commit into from Aug 8, 2018

Conversation

@evetsso
Copy link
Contributor

@evetsso evetsso commented Aug 8, 2018

Empty output folder allows galleries to be placed at the site's top directory,
instead of inside e.g. a "galleries" subdirectory. But without this change, the
plugin would want to generate an index page that collides with the site's main
index page.

Pull Request Checklist

  • I’ve read the guidelines for contributing.
  • I updated AUTHORS.txt and CHANGES.txt (if the change is non-trivial) and documentation (if applicable).
  • I tested my changes.

Description

I don't think this requires a documentation change? Attempting to use an empty output folder for galleries I think just follows naturally without needing it explicitly mentioned?

Empty output folder allows galleries to be placed at the site's top directory,
instead of inside e.g. a "galleries" subdirectory.  But without this change, the
plugin would want to generate an index page that collides with the site's main
index page.

Fixes getnikola#3134
@evetsso evetsso force-pushed the gallery-toplevel branch from e742846 to 2297526 Aug 8, 2018
@Kwpolska Kwpolska merged commit 79dcd88 into getnikola:master Aug 8, 2018
3 checks passed
@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented Aug 8, 2018

Come to think of it, this breaks sites that are gallery-centric (who want the gallery index as main). I slightly amended it in commit 1220595.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants