Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove doctitle if not using reST docinfo metadata #3158

Merged
merged 3 commits into from Sep 6, 2018
Merged

Conversation

Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented Sep 6, 2018

This is #2382, #3124, and probably a lot of other issues.

New behavior: doctitle (first header) disappears only if USE_REST_DOCINFO_METADATA is true. I also re-implemented the feature in a less hacky way.

The old (but not well-known, even by the core devs) setting NO_DOCUTILS_TITLE_TRANSFORM was removed.

Kwpolska added 3 commits Sep 6, 2018
It was badly-implemented, not well documented, and USE_REST_DOCINFO_METADATA should be consulted instead. (#2382)

Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Fix #2382, Fix #3124.

Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@ralsina
Copy link
Member

@ralsina ralsina commented Sep 6, 2018

I like it. Even though it changes behaviour that has been there for a long time, that behaviour was really confusing anyway.

ralsina
ralsina approved these changes Sep 6, 2018
@Kwpolska Kwpolska merged commit 0ac289e into master Sep 6, 2018
4 of 5 checks passed
Version 8 automation moved this from To Do to Done Sep 6, 2018
@Kwpolska Kwpolska deleted the real-doctitle-fix branch Sep 6, 2018
Kwpolska added a commit that referenced this issue Sep 6, 2018
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Version 8
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants