Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3167 — fix docinfo removal for sites that use reST docinfo #3168

Merged
merged 2 commits into from Sep 18, 2018
Merged

Conversation

@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented Sep 18, 2018

This fixes #3167. cc @gwax.

It seems to work properly now with my testing, but it would be good if someone else also tested it (in particular, title removal with reST docinfo metadata both on and off)

Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@Kwpolska Kwpolska added the bug label Sep 18, 2018
@Kwpolska Kwpolska requested a review from gwax Sep 18, 2018
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@Kwpolska Kwpolska added this to the v8.0.1 milestone Sep 18, 2018
@gwax
gwax approved these changes Sep 18, 2018
Copy link
Contributor

@gwax gwax left a comment

I have confirmed that this fixes the problem in my usage.

🚢

@Kwpolska Kwpolska merged commit 7a60483 into master Sep 18, 2018
3 of 5 checks passed
3 of 5 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@Kwpolska Kwpolska deleted the fix-3167 branch Sep 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants