Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Markdown 3.0, fix some warnings #3175

Merged
merged 7 commits into from Nov 2, 2019
Merged

Use Markdown 3.0, fix some warnings #3175

merged 7 commits into from Nov 2, 2019

Conversation

@ralsina
Copy link
Member

@ralsina ralsina commented Oct 3, 2018

While Markdown 3.0 worked, it caused a lot of warnings because the extension API had changed. This PR makes Nikola work with 3.0 and ONLY with 3.0

Additionally, it fixes a python 3.7 warning and a pytest warning.

@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented Oct 3, 2018

ONLY with 3.0

Do you intend to add 2.x compatibility for this?

@ralsina
Copy link
Member Author

@ralsina ralsina commented Oct 3, 2018

@Kwpolska Kwpolska merged commit dd4fafb into master Nov 2, 2019
4 checks passed
@Kwpolska Kwpolska deleted the md3 branch Nov 2, 2019
@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented Nov 2, 2019

Tests pass, so I merged this. It’s certainly been a while this has been waiting without much reason to believe this should not be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants