Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Twitter cards does not require an opt-in anymore. #3186

Conversation

@okin
Copy link
Member

@okin okin commented Nov 27, 2018

Pull Request Checklist

  • I’ve read the guidelines for contributing.
  • I updated AUTHORS.txt and CHANGES.txt (if the change is non-trivial) and documentation (if applicable).
  • I tested my changes.

Description

When the Twitter card support was implemented this was something that required an opt-in in their developer platform.
This is not the case anymore and hints about this may be misleading because people do not find a way to opt-in.

@Kwpolska Kwpolska merged commit cf10154 into getnikola:master Nov 27, 2018
0 of 3 checks passed
0 of 3 checks passed
Codacy/PR Quality Review Hang in there, Codacy is reviewing your Pull request.
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented Nov 27, 2018

Good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants