SCHEDULE_FORCE_TODAY is redundant? #984

Merged
merged 1 commit into from Apr 21, 2014

4 participants

@gour

Hi,

further reading of the handbook has brought me to SCHEDULE_FORCE_TODAY setting, and by following the example from the handbook, it seems to be that instead of having SCHEDULE_FORCE_TODAY setting, the same thing could be accomplished by just using:

nikola new_post

without

--schedule

option, which would mean one setting less to take care of in Nikola?

@Kwpolska
Nikola, a static site generator member

cc @punchagan — the developer of the schedule feature.

@punchagan
Nikola, a static site generator member

SCHEDULE_FORCE_TODAY is redundant when SCHEDULE_ALL is set to False, but pretty useful when it is True.

@gour

My example was assuming SCHEDULE_ALL set to True. :-)

What would be the difference between have it set to True and posting new post without '--schedule'?

@punchagan
Nikola, a static site generator member

Let's say I have a conf that looks like this:

SCHEDULE_RULE = 'RRULE:FREQ=WEEKLY;BYDAY=MO,WE,FR;BYHOUR=8;BYMINUTE=0;BYSECOND=0'
SCHEDULE_ALL = True
SCHEDULE_FORCE_TODAY = True

(posts are scheduled at 8 am on M, W, F)

Running nikola new_post at 9pm on Wednesday, would schedule the post to be scheduled for 8am on the same day. If SCHEDULE_FORCE_TODAY was False, it would be scheduled for the following Friday, 8am.

If SCHEDULE_ALL is False and new_post is run, the post would get posted at the time when the command was run.

@gour

Running nikola new_post at 9pm on Wednesday, would schedule the post to be scheduled for 8am on the same day.

Does it really makes sense?

If SCHEDULE_FORCE_TODAY was False, it would be scheduled for the following Friday, 8am.

That is the same as running:

new_post --schedule

right?

If SCHEDULE_ALL is False and new_post is run, the post would get posted at the time when the command was run.

It means that SCHEDULE_ALL = False does not bring anything important/new to the table, and, all in all, tehe question is whether all those settings are worth to be kept?

@punchagan
Nikola, a static site generator member

Running nikola new_post at 9pm on Wednesday, would schedule the post to be scheduled for 8am on the same day.

Does it really makes sense?

May be not.

@ralsina
Nikola, a static site generator member

I totally don't understand this issue. Close/keep Open?

@gour

I totally don't understand this issue. Close/keep Open?

Fix by removing SCHEDULE_FORCE_TODAY option which does not serve any purpose as demonstrated above and/or can be accomplished by other options.

@punchagan
Nikola, a static site generator member

Please go ahead and remove it. I am not using scheduling much, and don't have any strong opinions either way.

@ralsina ralsina merged commit edd8e4b into master Apr 21, 2014

1 check failed

Details continuous-integration/travis-ci The Travis CI build failed
@ralsina ralsina deleted the remove-schedule_force_today branch Apr 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment