Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tx3 tag cloud #101

Merged
merged 2 commits into from Aug 21, 2015
Merged

Tx3 tag cloud #101

merged 2 commits into from Aug 21, 2015

Conversation

@humitos
Copy link
Member

humitos commented Aug 21, 2015

Implemented tx3TagCloud (https://github.com/Tuxes3/tx3TagCloud) as a Nikola plugin.

humitos added 2 commits Aug 16, 2015
tag_cloud_data[tag] = [len(posts), self.site.link(
'tag', tag, self.site.config['DEFAULT_LANG'])]
output_name = os.path.join(kw['output_folder'],
'assets', 'js', 'tx3_tag_cloud.json')

This comment has been minimized.

Copy link
@Kwpolska

Kwpolska Aug 21, 2015

Member

Why can’t you use tag_cloud_data.json?

This comment has been minimized.

Copy link
@humitos

humitos Aug 21, 2015

Author Member

Because that task adds a lot of information that is not needed and make the render to be slow. Take a look at the difference in my blog site:

(blog)[12:45] humitos: nikola> ls -lah ./output/assets/js/tx3_tag_cloud.json ./output/assets/js/tag_cloud_data.json
-rw-rw-r-- 1 humitos humitos 279K ago 21 12:44 ./output/assets/js/tag_cloud_data.json
-rw-rw-r-- 1 humitos humitos 3,6K ago 20 22:11 ./output/assets/js/tx3_tag_cloud.json
(blog)[12:45] humitos: nikola>

3.6Kb against 279Kb. It's too much!

Kwpolska added a commit that referenced this pull request Aug 21, 2015
Tx3 tag cloud
@Kwpolska Kwpolska merged commit de2a602 into master Aug 21, 2015
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
@Kwpolska
Copy link
Member

Kwpolska commented Aug 21, 2015

guess we can merge.

@ralsina ralsina deleted the tx3TagCloud branch Aug 21, 2015
@Kwpolska
Copy link
Member

Kwpolska commented Aug 24, 2015

via @jjconti in the plugin comments: Is another step needed?

@Kwpolska
Copy link
Member

Kwpolska commented Aug 24, 2015

I needed to delete/* and regenerate to see it action :)

@humitos, it looks like there’s a dependency problem — mind investigating further?

@humitos
Copy link
Member Author

humitos commented Sep 3, 2015

@jjconti @Kwpolska I will investigate it. I just need some free time, but I read the comment. Sorry guys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.