Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to work with Python3 #119

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@jjconti
Copy link
Contributor

commented Oct 2, 2015

As Nikola is dropping support for Python2 there is no point in having a not merged plugin working on 2 and not on 3.

Fix to work with Python3
As Nikola is dropping support for Python2 there is no point in having a not merged plugin working on 2 and not on 3.
% for k, v in options.iteritems():
% if isinstance(v, unicode):
% for k, v in options.items():
% if isinstance(v, str):

This comment has been minimized.

Copy link
@ralsina

ralsina Oct 2, 2015

Member

If you really want to keep this working in python2, you could use nikola.utils.unicode_str which is always the right thing.

This comment has been minimized.

Copy link
@Kwpolska

Kwpolska Oct 2, 2015

Member

Is it accessible from within templates? (and why is there so much logic in this template?)

@ralsina

This comment has been minimized.

Copy link
Member

commented Mar 8, 2018

This PR seems to apply to a plugin that is not there anymore?

@ralsina ralsina closed this Mar 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.