Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added German slugifying plugin. #145

Merged
merged 3 commits into from Mar 12, 2016
Merged

Added German slugifying plugin. #145

merged 3 commits into from Mar 12, 2016

Conversation

felixfontein
Copy link
Contributor

@felixfontein felixfontein commented Mar 11, 2016

Uses Nikola's newest feature (getnikola/nikola#2284) to transform ä,ö,ü,ß to ae,oe,ue,ss for German languages.

@felixfontein
Copy link
Contributor Author

@felixfontein felixfontein commented Mar 11, 2016

Fixes getnikola/nikola#2172 and getnikola/nikola#2273.

"""Checks whether the given language name with corresponding locale needs German slugifying rules."""
if locale.split('_')[0] in {'de', 'gsw'}: # German and Allemanic German
return True
if lang in {'de', 'deutsch', 'german',
Copy link
Member

@Kwpolska Kwpolska Mar 11, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where would you get all those broken strings from?

Copy link
Contributor Author

@felixfontein felixfontein Mar 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed 'deutsch' and 'german'. I left the others as I don't know of another way to distinguish between different german locales.

Kwpolska added a commit that referenced this issue Mar 12, 2016
Added German slugifying plugin.
@Kwpolska Kwpolska merged commit 4d45ff6 into master Mar 12, 2016
2 checks passed
@Kwpolska Kwpolska deleted the german-umlauts branch Mar 12, 2016
@felixfontein
Copy link
Contributor Author

@felixfontein felixfontein commented Mar 12, 2016

Thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants