Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publication_list: enable multiple highlight authors #187

Merged
merged 3 commits into from Nov 21, 2016

Conversation

@cycomanic
Copy link
Contributor

@cycomanic cycomanic commented Nov 16, 2016

Bibtex files (especially when pulled from different sources) often contain authors in different formats or spelling, for example I have entries with Jochen Schroeder, Jochen Schröder and just initials. This (small) change enables to specify a comma separated list of highlight authors which will be highlighted. I left the option name unchanged (highlight_author, singular) to not break existing sites.

@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented Nov 16, 2016

Could , appear if someone is doing Lastname, Firstname? If yes, ; would work better instead.

Also, please add your @gmail.com e-mail address to GitHub settings to ensure proper attribution of commits.

@xuhdev
Copy link
Member

@xuhdev xuhdev commented Nov 16, 2016

I agree with @Kwpolska that you probably want a different delimiter.

@cycomanic
Copy link
Contributor Author

@cycomanic cycomanic commented Nov 21, 2016

Ok, I changed this to semicolon delimited

@Kwpolska Kwpolska merged commit 2e4ab9b into getnikola:master Nov 21, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented Nov 21, 2016

Thanks for contributing to Nikola!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants