Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for new compile_string interface #202

Merged
merged 5 commits into from Jan 8, 2017

Conversation

@felixfontein
Copy link
Contributor

felixfontein commented Jan 8, 2017

To be merged when getnikola/nikola#2624 is done.

@@ -190,7 +190,14 @@ def __formatData(self, data, context, source=None):
_LOGGER.warning("The post '" + source + "' still contains shortcodes: " + str(left_shortcodes))
return output

def compile_string(self, data, source_path=None, is_two_file=True, post=None, lang=None):
"""New interface. Might be removed at some time."""

This comment has been minimized.

Copy link
@Kwpolska

Kwpolska Jan 8, 2017

Member

Oh come on, we are not that unstable. (this docstring could be more helpful anyways)

This comment has been minimized.

Copy link
@felixfontein

felixfontein Jan 8, 2017

Author Contributor

That's not what I wanted to write :)

@felixfontein
Copy link
Contributor Author

felixfontein commented Jan 8, 2017

Can you also take a look at 3d73684?

@Kwpolska
Copy link
Member

Kwpolska commented Jan 8, 2017

Makes sense.

@felixfontein
Copy link
Contributor Author

felixfontein commented Jan 8, 2017

Good. Then let's merge this as soon as getnikola/nikola#2623 is merged.

@felixfontein felixfontein merged commit 953493f into master Jan 8, 2017
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
@felixfontein felixfontein deleted the supporting-new-interface branch Jan 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.