Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #221 -- add dependencies in pkgindex_compiler #222

Merged
merged 1 commit into from Apr 7, 2017
Merged

Fix #221 -- add dependencies in pkgindex_compiler #222

merged 1 commit into from Apr 7, 2017

Conversation

@Kwpolska
Copy link
Member

Kwpolska commented Apr 2, 2017

I’m using add='both' implicitly, because some of those files do not appear in cache/*.html.

I’m using `add='both'` implicitly, because some of those files do not
appear in `cache/*.html`.

Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@Kwpolska Kwpolska requested a review from felixfontein Apr 2, 2017
@felixfontein

This comment has been minimized.

Copy link
Contributor

felixfontein commented Apr 2, 2017

This is a good start, but there are still things which don't result in proper dependencies, for example config['demo_screenshots_map'] in parse_theme_info: if that changes, no post is being recompiled.

It might be really better to simply do an uptodate dependency in CompilePackageIndexEntries.read_metadata on metadata returned there, since that implicitly covers all the other added dependencies.

@felixfontein

This comment has been minimized.

Copy link
Contributor

felixfontein commented Apr 2, 2017

(And yes, add='both' is best here.)

Copy link
Contributor

felixfontein left a comment

What I wrote above. I think a single uptodate dependency for the collected metadata is better, but this also works (even though it is more error-prone). Feel free to either change or merge (or whatever else ;) ).

@Kwpolska Kwpolska merged commit eedc402 into master Apr 7, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@Kwpolska Kwpolska deleted the fix-221 branch Apr 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.