Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve latex formula renderer (bugfixes, refactoring, adding support for other TeX engines) #224

Merged
merged 11 commits into from Apr 15, 2017

Conversation

@felixfontein
Copy link
Contributor

felixfontein commented Apr 15, 2017

The new version should be backwards compatible to old instances of the latex compiler plugin (and other plugins).

Also includes a fix for the latex compiler plugin to allow setting the TeX engine for formula rendering.

@@ -89,6 +89,7 @@ def __init__(self):
super(LatexImageFormulaRenderer, self).__init__()
self.__formula_scale = 1.25

This comment has been minimized.

Copy link
@Kwpolska

Kwpolska Apr 15, 2017

Member

PS. I really dislike those double underscores.

This comment has been minimized.

Copy link
@felixfontein

felixfontein Apr 15, 2017

Author Contributor

Because they look ugly, because they don't really give privacy, or because of something else?

This comment has been minimized.

Copy link
@Kwpolska

Kwpolska Apr 15, 2017

Member

That, and they may mess up in some situations where you never expect it. This probably won’t happen in a Nikola plugin that doesn’t get inherited though.

'programs': ['lualatex'],
'head': R"""\RequirePackage{luatex85}
\documentclass{standalone}
\usepackage[T1]{fontenc}

This comment has been minimized.

Copy link
@Kwpolska

Kwpolska Apr 15, 2017

Member

\usepackage{fontspec} would be a better choice for LuaTeX.

This comment has been minimized.

Copy link
@felixfontein

felixfontein Apr 15, 2017

Author Contributor

Good idea.

@Kwpolska
Copy link
Member

Kwpolska commented Apr 15, 2017

(Merge at will, since plugins do not require reviews.)

@felixfontein felixfontein merged commit 644f70b into master Apr 15, 2017
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@felixfontein felixfontein deleted the improve-latex-formula-renderer branch Apr 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.