Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the gallery directive less of a hack #226

Merged
merged 2 commits into from May 8, 2017
Merged

Conversation

ralsina
Copy link
Member

@ralsina ralsina commented May 4, 2017

gallery in bootstrap, either.

* It will look bad in most other themes. But you can customize it by
creating your own gallery_fancy.tmpl. Here's the one that comes with
Copy link
Member

@Kwpolska Kwpolska May 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

git add templates/; git commit -am "Forgot gallery_fancy templates"

(also, gallery_directive.tmpl might be a better name)

Copy link
Member Author

@ralsina ralsina May 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. It's not on this computer, will push tomorrow.

Copy link
Member

@Kwpolska Kwpolska left a comment

LGTM!

@ralsina ralsina merged commit c1a23b7 into master May 8, 2017
2 checks passed
@ralsina ralsina deleted the fix-gallery-directive branch May 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants