Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapted to Nikola v8. Changed some incompatible legends #248

Closed
wants to merge 1 commit into from

Conversation

@marian-vignau
Copy link

@marian-vignau marian-vignau commented Sep 15, 2017

Fix bugs that prevent plugin from render, changing "Recent Posts" to "Newer posts" and "Archives" to "Archive"

@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented Sep 16, 2017

  1. What did you change for Nikola v8?
  2. Did you read the README? Note that the default templates expect some extra messages (translations) — and those missing ones are the ones you had trouble with.

Copy link
Member

@Kwpolska Kwpolska left a comment

(blocking merge until questions are answered)

@felixfontein
Copy link
Contributor

@felixfontein felixfontein commented Sep 16, 2017

For me, the v7 plugin was working fine with Nikola v8.

@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented Sep 17, 2017

I ran a diff, only the templates were changed to substitute messages. As such, we have to refuse this change — the Nikola v7 plugin works fine, as long as you read the README file and add the missing translations by yourself.

@Kwpolska Kwpolska closed this Sep 17, 2017
@felixfontein
Copy link
Contributor

@felixfontein felixfontein commented Sep 17, 2017

Or use a different (customized) template. The included ones are only examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants