Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

header_and_footer plugin #52

Closed
wants to merge 4 commits into from
Closed

Conversation

reedwade
Copy link

@reedwade reedwade commented Aug 24, 2014

A new plugin that makes it easier provide site markup to things like the nginx fancy indexer by splitting a generated sample posting file in two.

Review on Reviewable

#
# TODO: does this cover all the cases we care about?
#
contents = contents.replace('="../', '="/')
Copy link
Member

@Kwpolska Kwpolska Aug 24, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can break in an awful lot of cases. In order to really fix this, some changes would have to go into Nikola core — a real solution is to change the url_type for this one post (or force users to change it site-wide)

Copy link
Author

@reedwade reedwade Aug 24, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll investigate this.

thanks,
-reed

@Kwpolska
Copy link
Member

Kwpolska commented Jul 5, 2015

Any updates on this, or should I close?

@reedwade reedwade closed this Jul 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants