fix(landing): prevent docs sidebar from scrolling with page content#141
Conversation
Use fixed positioning for the sidebar placeholder instead of sticky, which was broken by nested scroll containers. The sidebar now stays in place while content scrolls independently.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughReplaced an outer wrapper by rendering Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@landing/src/app/docs/layout.tsx`:
- Line 182: There's a typo in the JSX className on the div that reads "flew-row
flex items-center" which makes the row layout class a no-op; update the
className on that div (the element in layout.tsx that currently has "flew-row
flex items-center") to use the correct Tailwind utility "flex-row" so it becomes
"flex-row flex items-center" (or reorder to "flex flex-row items-center" if you
prefer the explicit flex container first).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 50dbbec4-3766-47e8-8354-bd98ee8f1a05
📒 Files selected for processing (3)
landing/src/app/docs/layout.tsxlanding/src/components/layout/navigation-bar.tsxlanding/src/styles/globals.css
Pin sidebar background-color to var(--sidebar) so CSS layer resolution differences between dev and prod builds don't cause color mismatches. Remove dead duplicate --sidebar declaration. Fix "flew-row" typo.
Summary
divwithh-dvh overflow-y-autoaroundDocsLayoutthat created a nested scroll container breaking sticky positioningposition: fixedto the sidebar placeholder via CSS, matching the approach used by better-auth's fumadocs setupTest plan
Summary by CodeRabbit
Refactor
Style
Bug Fixes