Skip to content

Enable brand menu on mobile headers#166

Merged
maxktz merged 1 commit into
mainfrom
fix/mobile-brand-menu
Apr 30, 2026
Merged

Enable brand menu on mobile headers#166
maxktz merged 1 commit into
mainfrom
fix/mobile-brand-menu

Conversation

@maxktz

@maxktz maxktz commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

Summary

  • enable the shared brand context menu in the mobile main header and mini header
  • reuse BrandMenu across header variants so copy logo / copy wordmark works consistently on small screens too
  • keep the existing mobile spacing and wordmark sizing aligned with the current header styles

Testing

  • bun typecheck

Summary by CodeRabbit

  • Refactor
    • Streamlined navigation component structure by consolidating brand menu and logo rendering logic, improving code reusability and maintainability across navigation components while enabling flexible styling customization.

@vercel

vercel Bot commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
paykit Ready Ready Preview, Comment Apr 30, 2026 4:07pm

@coderabbitai

coderabbitai Bot commented Apr 30, 2026

Copy link
Copy Markdown

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 94bf37d8-899a-4044-9da5-56e3da3308db

📥 Commits

Reviewing files that changed from the base of the PR and between 2907558 and cdb9040.

📒 Files selected for processing (3)
  • apps/web/src/components/layout/mini-nav-bar.tsx
  • apps/web/src/components/layout/navigation-bar.tsx
  • apps/web/src/components/web/brand-menu.tsx

📝 Walkthrough

Walkthrough

This refactor consolidates logo and brand link rendering into the BrandMenu component by adding optional styling props (className, linkClassName, wordmarkClassName), allowing navigation components to delegate structure while customizing appearance.

Changes

Cohort / File(s) Summary
Navigation Components
apps/web/src/components/layout/mini-nav-bar.tsx, apps/web/src/components/layout/navigation-bar.tsx
Removed explicit Link and Wordmark component usage and delegated to BrandMenu with linkClassName and wordmarkClassName props for styling control.
Brand Menu Component
apps/web/src/components/web/brand-menu.tsx
Added optional className, linkClassName, and wordmarkClassName props; merged them into existing class strings using cn() utility to preserve base styling while accepting caller overrides.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • PR #165: Both PRs modify the same brand/navigation components (brand-menu.tsx, mini-nav-bar.tsx, navigation-bar.tsx); this PR adds styling props and delegates component structure while PR #165 updates wordmark sizing and assets—directly related changes to the same component family.

Poem

🐰 The brand shall flow through menus clean,
With styling props passed down serene,
No more inline links we weave,
Just flexible props we now receive,
A hop of grace, a delegation spree! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: enabling the brand menu component on mobile headers by refactoring two mobile header files to use the BrandMenu component.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/mobile-brand-menu

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@maxktz maxktz merged commit 61fcdcc into main Apr 30, 2026
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant