New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling the cache breaks push to Dokku #6

Open
dave-tucker opened this Issue Aug 13, 2014 · 7 comments

Comments

Projects
None yet
4 participants
@dave-tucker
Contributor

dave-tucker commented Aug 13, 2014

The last patch to disable the cache causes push to Dokku to fail...

remote: rm: cannot remove `/cache': Device or resource busy

Appreciate that this may not work on Heroku, but raising the bug to ensure any Dokku users either revert the patch in question or use my fork (where I've fixed this) until the cache issue is resolved.

@kylef

This comment has been minimized.

Member

kylef commented Aug 14, 2014

@dave-tucker I don't see how this has anything to do with Dokku, this is a buildpack for Heroku. Hence the repository name. This is designed to work for Heroku.

@kylef kylef closed this Aug 14, 2014

@dave-tucker

This comment has been minimized.

Contributor

dave-tucker commented Aug 14, 2014

@kylef Dokku uses Heroku Buildpacks. If you feel that strongly about it, I'll maintain a permanent fork of this repo for Dokku and not bother pushing back upstream.

@kylef

This comment has been minimized.

Member

kylef commented Aug 14, 2014

@dave-tucker Hmm, I didn't know Dokku is heroku compatible thing. I'd be willing to accept a pull-request adding support for Dokku if you would like to make one.

The cache was disabled because it's not working correctly and actually causing the nginx install to break every time you push to Heroku with an existing cache. (I'd love to actually make the cache work but I haven't found the time to fix it).

@dave-tucker

This comment has been minimized.

Contributor

dave-tucker commented Aug 14, 2014

@kylef the changes required were pushed in #4 (along with support for PCRE) which removed the "rm -rf $CACHE_DIR".

Adding this back has caused a regression from my standpoint (as a Dokku user) hence raising the bug.

This repo's purpose is to serve Heroku users first and foremost but I think it's still worthwhile leaving this bug open until the cache issue is fixed as an FYI for any users of Dokku... if I can find some spare cycles I'll see if I can look in to the issue further... it may also help to have an issue raised for that too.

@kylef kylef reopened this Aug 26, 2014

@kylef

This comment has been minimized.

Member

kylef commented Aug 26, 2014

@dave-tucker I think I'll add a environmental variable to enable the cache, something like PELICAN_USE_BUILD_CACHE or something which you can set to true to enable (disabled by default).

When it's working, we will just change the default to true and it will allow people to opt-out.

@Chris2048

This comment has been minimized.

Chris2048 commented Dec 3, 2016

This is an issue as cache deletion was re-introduced;
Can we add the env-var?

@born2discover born2discover referenced a pull request that will close this issue Jul 19, 2017

Open

Env var behaviour for cache removal. #15

@born2discover

This comment has been minimized.

born2discover commented Jul 19, 2017

@Chris2048 and @kylef having myself experienced issues when deploying to Dokku, I believe I've found a solution as described here: #15.

What do you guys think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment