New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move additional CSS/JS to separate files, include only in article pages. #252

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
1 participant
@prisae
Copy link

prisae commented Aug 2, 2014

I love this plugin and plan to use it for my site. To do so, I adjusted few things that bugged me. I don't know if these are generally wanted features or not - merge if wanted!

Issues it addresses:

  • The current version puts about 1600 lines of mainly css and some javascript into the html-header.
  • It includes this massive header on each page.
  • Site-specific css are hard-coded in the plugin.

The changes address the issues in the following way:

  • The additional css/js is put into separate files in the /theme/css and /theme/js directories.
  • The required header is only on the articles pages, and only if the tag 'ipynb' is present.
  • Site-specific css-changes have to be saved outside the plugin in 'output/theme/css/ipynb_mod.py'.

I am not familiar enough with the pelican code itself. The following could therefore be improved: The paths 'output/theme/css' and 'output/theme/js' are hard-coded. Pelican has, presumably, variables containing these paths. These variables should be used instead.

Thanks for the great plugin!
Dieter

@prisae

This comment has been minimized.

Copy link

prisae commented Oct 11, 2014

Git-novice as I was, I used the master branch for this pull request. I close it therefore.

@prisae prisae closed this Oct 11, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment