Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rmd_reader: handle backslashes in filenames #464

Merged
merged 1 commit into from May 2, 2015

Conversation

Projects
None yet
3 participants
@almartin82
Copy link
Contributor

commented Apr 13, 2015

on windows machines, rmd filenames that include c:\Users will raise an error unless \ are replaced with \\

handle backslashes in filenames
on windows machines, rmd filenames that include `c:\Users` will raise an error unless `\` are replaced with `\\`
@almartin82

This comment has been minimized.

Copy link
Contributor Author

commented Apr 17, 2015

@wilsonfreitas as the original author on this plugin can you do a quick code review here and tell me what you think? thanks!

@wilsonfreitas

This comment has been minimized.

Copy link
Contributor

commented Apr 20, 2015

It is ok. Can be merged!
Great work. Thanks.

@justinmayer

This comment has been minimized.

Copy link
Member

commented May 2, 2015

Thanks to Andrew for the enhancement and to Wilson for the review!

justinmayer added a commit that referenced this pull request May 2, 2015

Merge pull request #464 from almartin82/patch-1
rmd_reader: handle backslashes in filenames

@justinmayer justinmayer merged commit 7ad5210 into getpelican:master May 2, 2015

inktrap pushed a commit to inktrap/pelican-knitr that referenced this pull request Dec 14, 2016

Merge pull request getpelican#464 from almartin82/patch-1
rmd_reader: handle backslashes in filenames
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.