New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change PAGES context variable to pages in all themes #437

Open
jerryasher opened this Issue Oct 2, 2016 · 4 comments

Comments

Projects
None yet
2 participants
@jerryasher

jerryasher commented Oct 2, 2016

Who "owns" the various themes? Referring to Remove PAGES; use pages instead #1767, it seems as though many (most) themes will break in 3.7.0.

Who "owns" the various themes in pelican-themes?
Would it be wrong to globally change all templates referencing PAGES?
I sense it would be, but what will the process be for updating the themes and when would it take place?

Are you interested in pull requests to fix one theme at a time? For instance, I am using zurb-F5-basic, would you like the changes to the base.html and index.html?

FWIW, I see:

$ find . -name \*html | xargs grep "in PAGES"
./aboutwilson/templates/base.html:                          {% for page in PAGES %}
./bootlex/templates/base.html:              {% for p in PAGES %}
./bootstrap/templates/base.html:                    {% for page in PAGES %}
./bootstrap2/templates/base.html:              {% for page in PAGES %}
./bootstrap2/templates/index.html:                {% for page in PAGES %}
./bootstrap2-dark/templates/base.html:              {% for page in PAGES %}
./bootstrap2-dark/templates/index.html:                {% for page in PAGES %}
./brownstone/templates/base.html:                                                        {% for page in PAGES %}
./built-texts/templates/base.html:          {% for page in PAGES %}
./cebong/templates/base.html:                {% for page in PAGES %}
./cebong/templates/index.html:    {% for page in PAGES %}
./dev-random/templates/includes/sidebar.html:          {% for p in PAGES %}
./dev-random2/templates/includes/sidebar.html:              {% for p in PAGES %}
./foundation-default-colours/templates/base.html:                             {% for pg in PAGES | sort(attribute='index') %}                                                                                                          
</div>
./gum/templates/base.html:              {% for p in PAGES %}
./gum/templates/sidebar.html:    {% for p in PAGES %}
./Just-Read/templates/base.html:        {% for p in PAGES %}
./lightweight/templates/menu.html:    {% for p in PAGES %}
./mnmlist/templates/base.html:                {% for page in PAGES %}
./monospace/templates/base.html:                {% for page in PAGES %}
./new-bootstrap2/templates/base.html:              {% for gpage in PAGES %}
./new-bootstrap2/templates/index.html:        {% for page in PAGES %}
./nmnlist/templates/base.html:                {% for page in PAGES %}
./notebook/templates/base.html:      {% for p in PAGES %}
./notmyidea-cms/templates/base.html:                {% for p in PAGES %}
./notmyidea-cms/templates/index.html:{% for page in PAGES %}
./notmyidea-cms-fr/templates/base.html:                {% for p in PAGES %}
./notmyidea-cms-fr/templates/index.html:{% for page in PAGES %}
./photowall/templates/base.html:                {% for pg in PAGES %}
./photowall/templates/index.html:    {% for page in PAGES %}
./simple-bootstrap/templates/base.html:                {% for p in PAGES %}
./sneakyidea/templates/base.html:                    {% for current_page in PAGES %}
./sneakyidea/templates/index.html:{% for page in PAGES %}
./SoMA/templates/index.html:        {% for page in PAGES %}
./SoMA2/templates/index.html:        {% for page in PAGES %}
./subtle/templates/base.html:                {% for page in PAGES %}
./subtle/templates/index.html:    {% for page in PAGES %}
./syte/templates/base.html:        {% for current_page in PAGES %}
./tuxlite_tbs/templates/base.html:        {% for page in PAGES %}
./tuxlite_zf/templates/base.html:        {% for page in PAGES %}
./tuxlite_zf/templates/index.html:    {% for page in PAGES %}
./waterspill/templates/base.html:        {% for page in PAGES %}
./waterspill-en/templates/base.html:            {% for page in PAGES %}
./zurb-F5-basic/templates/base.html:        {% for page in PAGES %}
./zurb-F5-basic/templates/index.html:    {% for page in PAGES %}
Dell15:~/d/workspace/upstream.pelican/pelican-themes (pages)
$ 
@justinmayer

This comment has been minimized.

Member

justinmayer commented Dec 12, 2016

Hey Jerry. Thanks for creating an issue to track this effort. Pelican 3.7 has been released, so now would indeed be a good time to effect this change. I think that a single pull request that updates all the themes in the repo would be just fine. Is that something you could help out with? (^_^)

@justinmayer justinmayer changed the title from In Pelican 3.6.4 PAGES is changed to pages. Just curious as to what the process of correcting the themes will look like to Change PAGES context variable to pages in all themes Dec 12, 2016

@jerryasher

This comment has been minimized.

jerryasher commented Dec 12, 2016

@jerryasher

This comment has been minimized.

jerryasher commented Jan 11, 2017

@jerryasher

This comment has been minimized.

jerryasher commented Jan 11, 2017

Ah... Well, I now see I didn't go through the submodules...

So I have now recursively checked out the submodules,
git clone --recursive git@github.com:getpelican/pelican-themes.git

and redid the above, to find 115 occurrences in 99 files.

You can find those here:
https://gist.github.com/jerryasher/b439f5e8075c9eef344881ac3dde3ceb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment