New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pelican-bootstrap3: Add PADDED_SINGLE_COLUMN_STYLE setting #508

Merged
merged 1 commit into from Apr 6, 2018

Conversation

Projects
None yet
4 participants
@pedrohdz
Contributor

pedrohdz commented Apr 29, 2017

The PADDED_SINGLE_COLUMN_STYLE allows the main page content to be
centered with padding on the sides.

This setting takes precidence over HIDE_SIDEBAR, ABOUT_ME, and
AVATAR, hiding the sidebar completely when PADDED_SINGLE_COLUMN_STYLE
is set to True.

Also cleaned up how the classes are assigned in the main content div.
Things were starting to get unreadable in there IMHO.

@pedrohdz

This comment has been minimized.

Contributor

pedrohdz commented Oct 10, 2017

@justinmayer, anyone? :-)
Any chance of getting this merged? If not, what can I do to improve the odds?

If you want to get a feel for what this looks like in production, check out my blog:

Many thanks!

@justinmayer

This comment has been minimized.

Member

justinmayer commented Oct 10, 2017

Any thoughts from the community on this? cc: @DandyDev @jranke @maparent @LutzCle @NathanHarrington

@jranke

This comment has been minimized.

Contributor

jranke commented Oct 10, 2017

Looks nice to me. I don't find time for testing though.

@DandyDev

This comment has been minimized.

Contributor

DandyDev commented Oct 10, 2017

I like the look of it. 2 remarks though:

  • I don't like the variable name. CLEAN_BLOG_CONTENT_STYLE refers to a specific bootstrap template that nobody knows. I prefer a more descriptive name. The look reminds me a bit of the "distraction free" mode that a lot of writing apps have these days. Maybe call it DISTRACTION_FREE_BLOG_STYLE? Or any other more descriptive name :)
  • I'd prefer adding an actual pelican-bootstrap3 site with this setting enabled as example in the README, as opposed to the clean-blog example, which is a totally different template
@pedrohdz

This comment has been minimized.

Contributor

pedrohdz commented Oct 11, 2017

Thank you so much for the feedback @jranke and @DandyDev!

@DandyDev,
Regarding "an actual pelican-bootstrap3 site", two things come to mind:

  1. I could create a temporary dummy site and take a couple of screenshots and add the PNGs to the project and embed them in the README?
  2. I could add a link to my site with the disclaimer that I am using heavily modified Bootstrap configuration with custom CSS.

On naming... I tried searching on "clean blog content style" and on "distraction free blog style" and the former yielded more relevant results. I am open to renaming it though, just a little iffy on DISTRACTION_FREE_BLOG_STYLE.

@DandyDev

This comment has been minimized.

Contributor

DandyDev commented Oct 11, 2017

I'd add a link to your site with the disclaimer. That's better than putting more screenshots in the README.

The problem with the name remains for me. Clean Blog is literally a name of a template that is not Pelican related. That makes it confusing :) Maybe something like SINGLE_PADDED_COLUMN_STYLE? That describes what actually happens

Anyone else want to chime in with a name?

@pedrohdz

This comment has been minimized.

Contributor

pedrohdz commented Oct 11, 2017

How about PADDED_SINGLE_COLUMN_STYLE? :-D

@DandyDev

This comment has been minimized.

Contributor

DandyDev commented Oct 11, 2017

DEAL!

@pedrohdz

This comment has been minimized.

Contributor

pedrohdz commented Oct 15, 2017

Sweet! I should be able to get the chance in in a couple of days. I'm in transit at the moment.

If anyone has any other suggestions, please let me know.

@pedrohdz pedrohdz changed the title from Added CLEAN_BLOG_CONTENT_STYLE setting to Added PADDED_SINGLE_COLUMN_STYLE setting Oct 20, 2017

@pedrohdz

This comment has been minimized.

Contributor

pedrohdz commented Oct 20, 2017

@DandyDev, (and anyone else),
Changes made. Please review and let me know what you think.

Thanks!

@DandyDev

This comment has been minimized.

Contributor

DandyDev commented Oct 27, 2017

Sorry for the late comment, I was on vacation :)

Looks good to me, let's merge this!

@pedrohdz

This comment has been minimized.

Contributor

pedrohdz commented Mar 10, 2018

Any chance of getting this merged? @DandyDev gave it the green light a few months ago. Is there anything else’s that should be changed?

Added PADDED_SINGLE_COLUMN_STYLE setting
The `PADDED_SINGLE_COLUMN_STYLE` allows the main page content to be
centered with padding on the sides.

This setting takes precidence over `HIDE_SIDEBAR`, `ABOUT_ME`, and
`AVATAR`, hiding the sidebar completely when `PADDED_SINGLE_COLUMN_STYLE`
is set to `True`.

Also cleaned up how the `class`es are assigned in the main content div.
Things were starting to get unreadable in there IMHO.
@justinmayer

This comment has been minimized.

Member

justinmayer commented Apr 6, 2018

Many thanks to @pedrohdz for the contribution and to @DandyDev and @jranke for reviewing. 🤘

@justinmayer justinmayer changed the title from Added PADDED_SINGLE_COLUMN_STYLE setting to pelican-bootstrap3: Add PADDED_SINGLE_COLUMN_STYLE setting Apr 6, 2018

@justinmayer justinmayer merged commit 68178af into getpelican:master Apr 6, 2018

@pedrohdz pedrohdz deleted the pedrohdz:clean_blog_content branch Apr 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment