Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pelican-bootstrap3] Update to bootstrap-3.4.1, bootswatch-3.4.1 #669

Merged
merged 2 commits into from Jan 15, 2020

Conversation

@jayaddison
Copy link
Contributor

jayaddison commented Dec 16, 2019

This cleans up lighthouse warnings about outstanding security vulnerabilities in bootstrap-3.3.4.

Thanks @StevenMaude for pointing out that it makes sense to update bootswatch at the same time as bootstrap.

This replaces a PR originally opened as #659 - I prematurely deleted the source repo, not realizing that I wouldn't be able to push further commits to that PR.

@jayaddison

This comment has been minimized.

Copy link
Contributor Author

jayaddison commented Dec 16, 2019

For future reference, the following bash script was useful to import the new bootswatch themes from the bootswatch-3.4.1 tarball.

for i in bootswatch-3.4.1/*/*.min.css;
do
  cp $i bootstrap.`basename \`dirname $i\``.min.css;
done;

The amelia theme was deprecated and removed since v3.2.0 and is removed here too.

@jayaddison

This comment has been minimized.

Copy link
Contributor Author

jayaddison commented Dec 16, 2019

@jayaddison

This comment has been minimized.

Copy link
Contributor Author

jayaddison commented Dec 18, 2019

cc @avaris @iKevinY (tagging you as recent committers/reviewers for Pelican, in case you can help for review; I'm not sure whether tagging @getpelican worked as a mention)

Copy link
Member

iKevinY left a comment

Seems fine to me, would be nice to get another review from someone who uses this theme though.

@jayaddison

This comment has been minimized.

Copy link
Contributor Author

jayaddison commented Dec 23, 2019

Thanks again @iKevinY!

@avaris

This comment has been minimized.

Copy link
Member

avaris commented Dec 24, 2019

I guess this is OK. I don't really know much about bootstrap :).

@jayaddison

This comment has been minimized.

Copy link
Contributor Author

jayaddison commented Jan 6, 2020

Thanks @avaris ! I've only used bootstrap (and bootswatch) as dependencies rather than being super familiar with them.

Hopefully the version bump is quite safe; I pulled in the upstream dist versions here, but it'd be nice if anyone could double-check / integrity-check them.

@jayaddison

This comment has been minimized.

Copy link
Contributor Author

jayaddison commented Jan 7, 2020

cc @justinmayer - just mentioning you on a couple of PRs which may be about ready for merge (glad to handle any additional feedback)

@jayaddison

This comment has been minimized.

Copy link
Contributor Author

jayaddison commented Jan 15, 2020

cc @Ninpo in case you might be able to provide a second opinion as a previous committer/library upgrader for this theme?

@Ninpo

This comment has been minimized.

Copy link

Ninpo commented Jan 15, 2020

No objections to this update, runs OK with my test copy.

@jayaddison

This comment has been minimized.

Copy link
Contributor Author

jayaddison commented Jan 15, 2020

Great to hear, thanks again.

@justinmayer

This comment has been minimized.

Copy link
Member

justinmayer commented Jan 15, 2020

Many thanks to @jayaddison for the contribution and to @avaris, @iKevinY, and @Ninpo for reviewing. 🚀

@justinmayer justinmayer merged commit 3408de0 into getpelican:master Jan 15, 2020
@jayaddison jayaddison deleted the jayaddison:pelican-bootstrap3-upgrade-bootstrap branch Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.