Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set followlinks=True in utils.py copy #1785

Closed
nkabir opened this issue Jul 24, 2015 · 7 comments
Closed

Set followlinks=True in utils.py copy #1785

nkabir opened this issue Jul 24, 2015 · 7 comments

Comments

@nkabir
Copy link

nkabir commented Jul 24, 2015

When using themes with symlinked assets, the default method of utils.copy does not copy all of the assets. This fixes the issue:

for src_dir, subdirs, others in os.walk(source_, followlinks=True):

Any objection to making that the default behavior?

@avaris
Copy link
Member

avaris commented Jul 28, 2015

Sounds good.

@justinmayer
Copy link
Member

Hi Norman. Would you submit a pull request, including docs and tests, that implements this? Before doing so, please read the Contributing Guidelines thoroughly. Thanks!

fboxwala added a commit to fboxwala/pelican that referenced this issue Nov 16, 2015
fboxwala added a commit to fboxwala/pelican that referenced this issue Nov 19, 2015
fboxwala added a commit to fboxwala/pelican that referenced this issue Nov 19, 2015
fboxwala added a commit to fboxwala/pelican that referenced this issue Nov 19, 2015
fboxwala added a commit to fboxwala/pelican that referenced this issue Nov 19, 2015
fboxwala added a commit to fboxwala/pelican that referenced this issue Nov 20, 2015
@tiagoasousa
Copy link

when will this patch be implemented? i have this issue if DELETE_OUTPUT_DIRECTORY is true then css file wil not be generated...

@justinmayer
Copy link
Member

A fix is currently pending better tests — see #1863.

@justinmayer
Copy link
Member

@nkabir / @networkpadawan: If you want to see a fix merged soon, please help out with test coverage in PR #1863.

@avaris
Copy link
Member

avaris commented Mar 24, 2018

Oh, i did this with #2306 and completely forgot there were previous issues/PRs regarding it. No tests though :(.

@justinmayer
Copy link
Member

Thanks to @avaris, the relevant change is now in master. Anyone want to contribute tests for that change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants