Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typogrify is incorrectly modifying page titles #1998

Closed
Cartroo opened this issue Aug 25, 2016 · 2 comments
Closed

Typogrify is incorrectly modifying page titles #1998

Cartroo opened this issue Aug 25, 2016 · 2 comments

Comments

@Cartroo
Copy link
Contributor

@Cartroo Cartroo commented Aug 25, 2016

I have Typogrify enabled on my site and since I created a page (not an article) with an ampersand in the title, I've noticed that the generated HTML ends up like this:

<title>Trips <span class="amp">&amp;</span>&nbsp;Events</title>

I'd be quite surpriesd if <span> isn't valid within the <head> section and certainly at least Chrome renders this text literally in the tab title.

I'm afraid I don't yet have a test case online (this is still a draft) but you can easily replicate by creating a page and using an ampersand in the Title metadata.

@avaris

This comment has been minimized.

Copy link
Member

@avaris avaris commented Aug 25, 2016

see #1930

@justinmayer

This comment has been minimized.

Copy link
Member

@justinmayer justinmayer commented Aug 25, 2016

As mentioned in the issue @avaris pointed out, themes should ensure tags are stripped from titles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.