Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

BeautifulSoup dependency missing #311

Closed
akavlie opened this Issue Apr 12, 2012 · 4 comments

Comments

Projects
None yet
3 participants
Contributor

akavlie commented Apr 12, 2012

pelican-import fails for me as follows:

Traceback (most recent call last):
  File "/Users/akavlie/envs/kavlie.net/bin/pelican-import", line 283, in <module>
    main(input_type, args.input, args.markup, args.output, dircat=args.dircat)
  File "/Users/akavlie/envs/kavlie.net/bin/pelican-import", line 242, in main
    fields2pelican(fields, out_markup, output_path, dircat=dircat)
  File "/Users/akavlie/envs/kavlie.net/bin/pelican-import", line 188, in fields2pelican
    for title, content, filename, date, author, categories, tags, in_markup in fields:
  File "/Users/akavlie/envs/kavlie.net/bin/pelican-import", line 14, in wp2fields
    from BeautifulSoup import BeautifulStoneSoup
ImportError: No module named BeautifulSoup

BeautifulSoup should be added to dependencies.

Owner

almet commented Apr 12, 2012

I don't want to add beautiful soup to the dependencies just for the
import script. People willing to use the import script will be prompted
to install it so I think it is enough.

This is because pelican itself does not depend on beautiful soup, and
adding it just for the import script (which not everyone uses) sounds
too much for me.

Please, everyone, tell me if you prefer to have a seemless XP regarding
this and I may change my opinion.

Thanks for reporting this, tho.

@almet almet referenced this issue Apr 12, 2012

Closed

Fix for issue 311 #313

Owner

justinmayer commented Apr 12, 2012

I agree, Alexis. I think we should limit dependencies to only those needed for core essential functionality.

Contributor

akavlie commented Apr 13, 2012

This makes sense, I'll submit code & doc improvements to make it more clear that there's a dependency for the importer.

akavlie added a commit to akavlie/pelican that referenced this issue Apr 13, 2012

Issue #311
Catch BeautifulSoup ImportError.

akavlie added a commit to akavlie/pelican that referenced this issue Apr 13, 2012

Issue #311, #312
Document BeautifulSoup & pandoc deps.
Owner

almet commented Jun 9, 2012

I don't remember if this made it to master. Closing for now, don't hesitate to issue a pull request if your doc changes aren't merged into master.

@almet almet closed this Jun 9, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment