ArticlesGenerator: Set blog=True consistently. Fixes #1631. #1632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foresto
changed the title
foresto
changed the title
|
Looks good to me. It's nice to have more information to work with when it comes to writing themes. |
justinmayer
added a commit
that referenced
this pull request
Feb 27, 2015
ArticlesGenerator: Set blog=True consistently. Fixes #1631.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the
ArticlesGeneratormethods setblog=Truewhen rendering templates, which could be very helpful for theme developers wanting to selectively include/exclude certain elements in blog templates vs. page templates. Unfortunately, the variable is set inconsistently. For example, it is present in the list of articles for a time period and in the list of authors, but not the list of articles for any one author. As far as I can tell, this makes it rather useless. This patch corrects the inconsistency.